Reset avatar before uploading to prevent caching issues #1547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodrigok
added a commit
that referenced
this pull request
Dec 2, 2015
Reset avatar before uploading to prevent caching issues
This was referenced Dec 24, 2020
This was referenced Sep 5, 2021
This was referenced Jan 12, 2022
This was referenced Feb 10, 2022
This was referenced Oct 27, 2023
This was referenced Dec 14, 2023
This was referenced Jan 5, 2024
This was referenced Mar 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a call to
RocketChatFileAvatarInstance.deleteFilebefore uploading avatars, which removes the file from store before uploading new one. This prevents caching issues when avatar is later changed by the same user. Fixes issue #1546.