Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Apply server side filters on Livechat lists #15717

Merged
merged 6 commits into from
Nov 4, 2019

Conversation

renatobecker-zz
Copy link

After replacing publications with the REST approach, the filters were being applied only on the client-side, so the results reflected only on data that had been fetched from the server without any filters, based on pagination only.
Now, the filters will be sent to the server through the REST endpoint.

@renatobecker-zz renatobecker-zz added this to the 2.3.0 milestone Nov 1, 2019
@renatobecker-zz renatobecker-zz added this to In progress in Omnichannel Roadmap via automation Nov 1, 2019
@renatobecker-zz renatobecker-zz changed the title [FIX] Apply server side filters to Livechat lists [FIX] Apply server side filters on Livechat lists Nov 1, 2019
Omnichannel Roadmap automation moved this from In progress to Needs review Nov 4, 2019
@renatobecker-zz
Copy link
Author

Hi @sampaiodiego, I just pushed the fixes related to the string concatenation.

Omnichannel Roadmap automation moved this from Needs review to Reviewer approved Nov 4, 2019
@renatobecker-zz renatobecker-zz merged commit 75f366c into develop Nov 4, 2019
Omnichannel Roadmap automation moved this from Reviewer approved to Done Nov 4, 2019
@renatobecker-zz renatobecker-zz deleted the fix-filter-livechat-lists-server-side branch November 4, 2019 14:34
@sampaiodiego sampaiodiego mentioned this pull request Nov 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants