Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] TypeError when trying to load avatar of an invalid room. #16699

Merged
merged 1 commit into from Feb 26, 2020
Merged

[FIX] TypeError when trying to load avatar of an invalid room. #16699

merged 1 commit into from Feb 26, 2020

Conversation

pierre-lehnen-rc
Copy link
Contributor

Closes #16290

@sampaiodiego sampaiodiego merged commit 2129f55 into develop Feb 26, 2020
@sampaiodiego sampaiodiego deleted the fix.16290 branch February 26, 2020 19:49
gabriellsh added a commit to Pranav2612000/Rocket.Chat that referenced this pull request Mar 3, 2020
@gabriellsh
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into pr/1…
01daadb 
…6643-Pranav2612000-develop

* 'develop' of github.com:RocketChat/Rocket.Chat: (71 commits)
  Fix omnichannel icon missing on sidebar (RocketChat#16775)
  [IMPROVE] Rename client-side term "Livechat" to "Omnichannel" (RocketChat#16752)
  [FIX] Language country has been ignored on translation load (RocketChat#16757)
  [FIX] Cannot edit Profile when Full Name is empty and not required (RocketChat#16744)
  [IMPROVE] Accept open formarts of text, spreadsheet, presentation for upload by default (RocketChat#16502)
  Removing Trailing Space (RocketChat#16470)
  Lazy load categories and marketplaceVersion (RocketChat#16258)
  Fix Docker preview image (RocketChat#16736)
  [FIX] Manual Register use correct state for determining registered (RocketChat#16726)
  [FIX] Rocket.Chat takes too long to set the username when it fails to send enrollment email (RocketChat#16723)
  [CHORE] Changed remaining SelectInput's to Select (RocketChat#16719)
  [CHORE] Update snap install instructions (RocketChat#16720)
  [FIX] TypeError when trying to load avatar of an invalid room. (RocketChat#16699)
  [FIX] Color setting editing issues (RocketChat#16706)
  [FIX] Console error on login (RocketChat#16704)
  [NEW] Add methods to include room types on dashboard (RocketChat#16576)
  [FIX] ie11 support (RocketChat#16682)
  Regression: Show upload errors (RocketChat#16681)
  [FIX] Delete messages while searching bug (RocketChat#16568)
  Use insertSync
  ...
sampaiodiego pushed a commit that referenced this pull request Mar 16, 2020
@pierre-lehnen-rc @sampaiodiego
[FIX] TypeError when trying to load avatar of an invalid room. (#16699)
c371875
@sampaiodiego sampaiodiego mentioned this pull request Mar 16, 2020
Merged
@sampaiodiego sampaiodiego mentioned this pull request Apr 9, 2020
Merged
@gbrian gbrian mentioned this pull request May 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sampaiodiego sampaiodiego sampaiodiego approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Exception in callback of async function: TypeError: Cannot read property 'prid' of undefined
2 participants
@pierre-lehnen-rc @sampaiodiego