Refactor components and views to Storybook compatibility #17800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tassoevan
changed the title
tassoevan
changed the title
tassoevan
changed the title
tassoevan
force-pushed
the
refactor/components-and-views
branch
from
0db115e
to
e01297c
Compare
tassoevan
force-pushed
the
refactor/components-and-views
branch
from
b6fdbf3
to
75cc674
Compare
ggazzo
changed the title
ggazzo
approved these changes
Jun 9, 2020
ggazzo
added a commit
that referenced
this pull request
Jun 9, 2020
…/new-threads * 'develop' of github.com:RocketChat/Rocket.Chat: [FIX] Importers progress sending too much update events to clients (#17857) [FIX] Omnichannel message link is broken in email notifications (#17843) [FIX] Logic for room type was inverted in edit panel (#17851) (#17853) Refactor components and views to Storybook compatibility (#17800) [FIX] Slack importer settings object (#17776) Create codeql-analysis.yml
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
As Storybook excels at quickly prototyping components, it was adopted some versions ago as an important tool to frontend development. As TypeScript modules were introduced containing typing errors, our development routine was compromised as the Webpack configuration is way more stricter than Meteor building.
Issue(s)
How to test or reproduce
Run
meteor npm run storybookon CLI.Screenshots
Types of changes
Checklist
Changelog
Further comments
Most of the typing errors were rough mistakes that indicate there is no type checking being performed. I'm guessing here, but it seems ESLint isn't capable of type checking as it verifies each file individually;
meteor node node_modules/.bin/tsc --noEmitdid the trick for me.