Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] New Omnichannel Past Chats list padding #17994

Merged
merged 4 commits into from Jun 22, 2020
Merged

[FIX] New Omnichannel Past Chats list padding #17994

merged 4 commits into from Jun 22, 2020

Conversation

renatobecker
Copy link
Contributor

@renatobecker renatobecker commented Jun 22, 2020 •
edited

Proposed changes

Fix padding according to the designed wireframe.

Issue(s)

How to test or reproduce

  • Open an Omnichannel conversation as an agent/manager
  • Open the Contact Past Chats List(Tabbar)

Screenshots

Mockup:
Untitled 2

Implementation:
Untitled 3

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

Further comments

@renatobecker renatobecker added this to the 3.4.0 milestone Jun 22, 2020
@renatobecker renatobecker added this to In progress in Omnichannel Roadmap via automation Jun 22, 2020
@renatobecker renatobecker removed the request for review from MarcosSpessatto June 22, 2020 12:47
@sampaiodiego sampaiodiego requested a review from a team June 22, 2020 12:52
@renatobecker renatobecker changed the title [FIX] New Omnichannel Past Chats list padding [FIX][WIP] New Omnichannel Past Chats list padding Jun 22, 2020
@renatobecker renatobecker changed the title [FIX][WIP] New Omnichannel Past Chats list padding [FIX] New Omnichannel Past Chats list padding Jun 22, 2020
Omnichannel Roadmap automation moved this from In progress to Reviewer approved Jun 22, 2020
@renatobecker renatobecker merged commit 9fe61d1 into develop Jun 22, 2020
Omnichannel Roadmap automation moved this from Reviewer approved to Done Jun 22, 2020
@renatobecker renatobecker deleted the fix-padding-new-omnichannel-past-chats-list branch June 22, 2020 14:49
gabriellsh added a commit that referenced this pull request Jun 22, 2020
@gabriellsh
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into fix/…
c3852b6 
…prune_discussions

* 'develop' of github.com:RocketChat/Rocket.Chat:
  Remove useLazyRef hook usage (#18003)
  [FIX] User is prompted to reset their password when logging in with OAuth provider (#18001)
  [FIX] Missing i18n key for setting: Verify Email for External Accounts (#18002)
  Regression: Cannot save avatar change on admin (#17999)
  [NEW][ENTERPRISE] Omnichannel multiple business hours (#17947)
  [FIX] New Omnichannel Past Chats list padding (#17994)
@sampaiodiego sampaiodiego mentioned this pull request Jun 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcosSpessatto MarcosSpessatto MarcosSpessatto approved these changes

Assignees

@ggazzo ggazzo

Labels
None yet
Projects
Omnichannel Roadmap
  
Done
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@renatobecker @MarcosSpessatto @ggazzo