Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Indie Hosters install image #19192

Merged
merged 1 commit into from Oct 14, 2020
Merged

Conversation

aradhya-gupta
Copy link
Contributor

@aradhya-gupta aradhya-gupta commented Oct 9, 2020

Proposed changes

  1. The image for IndieHosters is added to README.md (using raw HTML as markdown could not be used to resize the image).
  2. The letter 'h' in GitHub is capital and not small.

Issue(s)

Closes #19190

How to test or reproduce

Screenshots

Before
indiehostersNotVisible

After
indiehostersVisible

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

Further comments

@w3Abhishek
Copy link

This was originally reported by me and created pull request. Kindly look into it. #19138

Copy link
Member

@Sing-Li Sing-Li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@w3Abhishek
Copy link

LGTM

Please guys merge the PR. It's been a while

@sampaiodiego sampaiodiego merged commit a3d2bb1 into RocketChat:develop Oct 14, 2020
@sampaiodiego sampaiodiego changed the title Modify README.md Fix Indie Hosters install image Oct 14, 2020
@sampaiodiego sampaiodiego mentioned this pull request Nov 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IndieHosters image not visible in README.md
4 participants