Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] API does not return roles in private channels #21728

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

aditya-mitra
Copy link
Contributor

Proposed changes (including videos or screenshots)

The API endpoint - groups.roles did not return the roles to admin users.
Now, those with view-room-administration permission can get the response containing the roles in private room.

admin_can_access_group_roles_via_api_video.mp4

Issue(s)

Closes #12870

Steps to test or reproduce

Steps for the 2nd endpoint mentioned in #12870

Further comments

@aditya-mitra
Copy link
Contributor Author

@KevLehman Can you please review this? 😄

@KevLehman KevLehman requested a review from a team April 30, 2021 18:23
@CLAassistant
Copy link

CLAassistant commented Dec 17, 2021

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API-Call endpoints doesn't return list of owner of private channel.
3 participants