New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMPROVE] Update system messages' behavior in rooms #22018
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matheusbsilva137
changed the title
[IMPROVE] system messages
[IMPROVE] Update system messages' behavior in rooms
May 12, 2021
pierre-lehnen-rc
requested changes
May 14, 2021
pierre-lehnen-rc
requested changes
May 17, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change is working as expect when the system message is hidden in the room level, but when hiding a sysetm message using the admin setting, the room's lastMessage is still displaying it.
pierre-lehnen-rc
approved these changes
Jun 16, 2021
KevLehman
added a commit
that referenced
this pull request
Jun 21, 2021
This reverts commit 3afe072.
sampaiodiego
pushed a commit
that referenced
this pull request
Jun 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
lastMessage
when its "Hide System Messages" setting is updated;lastMessage
field when the previouslastMessage
is deleted -- system messages can now be set as last messages.Issue(s)
Task - ClickUp
Steps to test or reproduce
Further comments
The last message field (in the sidebar) displays the following message types (using i18n translation): uj (user joined), ul (user left), ut, livechat-close, livechat-started, room-archived, room-unarchived, room_e2e_enabled, room_e2e_disabled, au (user added), r (room name changed), ru (user removed), wm, user-muted, user-unmuted, subscription-role-added, subscription-role-removed.