Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Sidebar not closing when clicking on a channel #22271

Merged
merged 7 commits into from Jun 9, 2021
Merged

[FIX] Sidebar not closing when clicking on a channel #22271

merged 7 commits into from Jun 9, 2021

Conversation

dougfabris
Copy link
Member

@dougfabris dougfabris commented Jun 7, 2021 •
edited

Proposed changes (including videos or screenshots)

before

before

after

after

Issue(s)

Closes #19755

Steps to test or reproduce

  • change to any room using sidebar on safari mobile

Further comments

@dougfabris dougfabris requested a review from a team June 7, 2021 19:12
@tassoevan tassoevan added this to the 3.16.0 milestone Jun 8, 2021
tassoevan
tassoevan requested changes Jun 8, 2021
View reviewed changes
client/sidebar/hooks/useSidebarDisplay.ts Outdated Show resolved Hide resolved
client/sidebar/RoomList/SideBarItemTemplateWithData.js Outdated Show resolved Hide resolved
@dougfabris dougfabris requested a review from tassoevan June 9, 2021 18:35
@dougfabris dougfabris requested a review from tassoevan June 9, 2021 21:01
tassoevan
tassoevan previously approved these changes Jun 9, 2021
View reviewed changes
@tassoevan tassoevan dismissed their stale review June 9, 2021 21:27

Broken build

@tassoevan tassoevan merged commit ff5b7fc into develop Jun 9, 2021
@tassoevan tassoevan deleted the fix/sidebar-channel-click branch June 9, 2021 21:59
@dougfabris dougfabris changed the title [FIX] Sidebar not closing after when clicking on a channel [FIX] Sidebar not closing when clicking on a channel Jun 9, 2021
@sampaiodiego sampaiodiego mentioned this pull request Jun 28, 2021
Merged
@dougfabris dougfabris mentioned this pull request Oct 6, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tassoevan tassoevan tassoevan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.16.0
Development

Successfully merging this pull request may close these issues.

Sidebar in mobile webapp doesn't automatically close anymore
2 participants
@dougfabris @tassoevan