Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW] Collect data about LDAP, SAML, CAS and OAuth usage. #22719

Merged
merged 5 commits into from Jul 21, 2021

Conversation

pierre-lehnen-rc
Copy link
Contributor

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Copy link
Member

@ggazzo ggazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost there ;)

app/models/server/models/Users.js Outdated Show resolved Hide resolved
app/statistics/server/lib/getServicesStatistics.ts Outdated Show resolved Hide resolved
@ggazzo ggazzo requested a review from a team July 20, 2021 20:50
@ggazzo ggazzo merged commit 6efa012 into develop Jul 21, 2021
@ggazzo ggazzo deleted the ldap-data-collecting branch July 21, 2021 03:46
users: number;
}> {
const customOatuh = settings.get(/Accounts_OAuth_Custom-[^-]+$/mi);
return Object.fromEntries(customOatuh.map(({ key, value }) => [key, {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

customOatuh a typo we might want to fix 🙈

@geekgonecrazy
Copy link
Member

At some point we really should consider making that entire payload a type. It would make it much easier to work with. Right now to determine what type the value is supposed to be is a really involved exercise

@ggazzo ggazzo mentioned this pull request Jul 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants