Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW] Alpha Matrix Federation #23688

Merged
merged 22 commits into from
Apr 22, 2022
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
89ee547
POC - initial commit
alansikora Mar 30, 2022
2bc0237
POC - initial commit
alansikora Mar 30, 2022
d9f46ac
adding settings/better names
alansikora Apr 1, 2022
63e6965
a few patches to get it working
geekgonecrazy Apr 4, 2022
1cc4219
importing settings
alansikora Apr 6, 2022
ffd9fce
fixing automatic generation for yaml file
alansikora Apr 6, 2022
ea8d9a1
Some changes to the user creation flow to better support remote and
geekgonecrazy Apr 6, 2022
0eedbea
fixing config
alansikora Apr 7, 2022
2fc10e1
fix: fix wrong reference
MarcosSpessatto Apr 7, 2022
cb9801b
fix: fix prettier and lint
MarcosSpessatto Apr 7, 2022
5ee790b
better bridge setup
alansikora Apr 12, 2022
5d0a0ec
Merge branch 'develop' into feature/federation-v2
geekgonecrazy Apr 20, 2022
872f07e
clarify comment
geekgonecrazy Apr 20, 2022
4210300
revised yarn lock with the matrix-bridge dependency
geekgonecrazy Apr 21, 2022
49feb37
Fix typescript issues. Rename settings. Move to Federation section. A…
geekgonecrazy Apr 21, 2022
ee82669
Fix remaining linting errors
geekgonecrazy Apr 21, 2022
5aabad2
fix slashcommand definition for ts typescript check
geekgonecrazy Apr 21, 2022
8d07ef7
Merge branch 'develop' into feature/federation-v2
geekgonecrazy Apr 21, 2022
302e176
add migration to put settings into the Rocket.Chat Federation section
geekgonecrazy Apr 21, 2022
dbab8ab
remove migration. Its not needed
geekgonecrazy Apr 21, 2022
bad68f1
Remove unneeded Meteor.startup wrappers for settings registration
rodrigok Apr 21, 2022
109b443
Merge branch 'feature/federation-v2' of https://github.com/RocketChat…
rodrigok Apr 21, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions app/federation-v2/server/matrix-client/room.ts
Original file line number Diff line number Diff line change
Expand Up @@ -41,5 +41,8 @@ export const create = async (user: IUser, room: IRoom): Promise<ICreateRoomResul
// Add to the map
MatrixBridgedRoom.insert({ rid: room._id, mri: matrixRoom.room_id });

// Add our user TODO: Doing this I think is un-needed since our user is the creator of the room. With it in.. there were errors
//await intent.invite(matrixRoom.room_id, userMatrixId);

return { rid: room._id, mri: matrixRoom.room_id };
};
67 changes: 40 additions & 27 deletions app/federation-v2/server/matrix-client/user.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@ import { MatrixProfileInfo } from 'matrix-bot-sdk';
import { IUser } from '../../../../definition/IUser';
import { matrixBridge } from '../bridge';
import { MatrixBridgedUser, MatrixBridgedRoom, Users } from '../../../models/server';
import { getConfig } from '../config';
import { addUserToRoom } from '../../../lib/server/functions';
import { config } from '../config';
import { matrixClient } from '.';
import { dataInterface } from '../data-interface';

Expand All @@ -16,6 +17,21 @@ interface ICreateUserResult {
export const invite = async (inviterId: string, roomId: string, invitedId: string): Promise<void> => {
console.log(`[${inviterId}-${invitedId}-${roomId}] Inviting user ${invitedId} to ${roomId}...`);

// Find the inviter user
let inviterUser = MatrixBridgedUser.getById(inviterId);
// Get the user
const user = await dataInterface.user(inviterId);

// The inviters user doesn't yet exist in matrix
if (!inviterUser) {
console.log(`[${inviterId}-${invitedId}-${roomId}] Creating remote inviter user...`);

// Create the missing user
inviterUser = await matrixClient.user.createRemote(user);

console.log(`[${inviterId}-${invitedId}-${roomId}] Inviter user created as ${inviterUser.mui}...`);
}
geekgonecrazy marked this conversation as resolved.
Show resolved Hide resolved

// Find the bridged room id
let matrixRoomId = await MatrixBridgedRoom.getMatrixId(roomId);

Expand All @@ -33,40 +49,29 @@ export const invite = async (inviterId: string, roomId: string, invitedId: strin
console.log(`[${inviterId}-${invitedId}-${roomId}] Remote room created as ${matrixRoomId}...`);
}

// Find the inviter user
let inviterUser = MatrixBridgedUser.getById(inviterId);

if (!inviterUser) {
console.log(`[${inviterId}-${invitedId}-${roomId}] Creating remote inviter user...`);

// Get the user
const user = await dataInterface.user(inviterId);

// Create the missing user
inviterUser = await matrixClient.user.createRemote(user);

console.log(`[${inviterId}-${invitedId}-${roomId}] Inviter user created as ${inviterUser.mui}...`);
}

// Normalize the user situation
// If the user does not exist locally, we might need to create one

// Determine if the user is local or remote
let invitedUserMatrixId = invitedId;
const invitedUserDomain = invitedId.includes(':') ? invitedId.split(':').pop() : '';
const invitedUserIsRemote = invitedUserDomain && invitedUserDomain !== getConfig().homeserverDomain;

console.log(invitedUserMatrixId, invitedUserDomain, invitedUserIsRemote);

// Find the invited user in Rocket.Chats users
let invitedUser = Users.findOneByUsername(invitedId.replace('@', ''));

if (!invitedUser) {
// Create the invited user
invitedUser = await matrixClient.user.createLocal(invitedUserMatrixId);
}
geekgonecrazy marked this conversation as resolved.
Show resolved Hide resolved

// If the invited user is not remote, let's ensure it exists remotely
if (!invitedUserIsRemote) {
console.log(`[${inviterId}-${invitedId}-${roomId}] Creating remote invited user...`);

// Find the invited user
const invitedUser = Users.findOneByUsername(invitedId.replace('@', ''));
let existingMatrixId = false;

// Check if we already have a matrix id for that user
const existingMatrixId = MatrixBridgedUser.getMatrixId(invitedUser._id);
existingMatrixId = MatrixBridgedUser.getMatrixId(invitedUser._id);

if (!existingMatrixId) {
const { mui } = await matrixClient.user.createRemote(invitedUser);
Expand All @@ -79,17 +84,25 @@ export const invite = async (inviterId: string, roomId: string, invitedId: strin
console.log(`[${inviterId}-${invitedId}-${roomId}] Invited user created as ${invitedUserMatrixId}...`);
}

console.log(`[${inviterId}-${invitedId}-${roomId}] Inviting the user...`);

// Invite the user
await matrixBridge.getIntent(inviterUser.mui).invite(matrixRoomId, invitedUserMatrixId);
console.log(`[${inviterId}-${invitedId}-${roomId}] Inviting the user to the room...`);

// Auto-join if the user is Rocket.Chat controlled
// Invite && Auto-join if the user is Rocket.Chat controlled
if (!invitedUserIsRemote) {

// Invite the user to the room
await matrixBridge.getIntent(inviterUser.mui).invite(matrixRoomId, invitedUserMatrixId);

console.log(`[${inviterId}-${invitedId}-${roomId}] Auto-join room...`);

await matrixBridge.getIntent(invitedUserMatrixId).join(matrixRoomId);
} else {
// Invite the user to the room but don't wait as this is dependent on the user accepting the invite because we don't control this user
matrixBridge.getIntent(inviterUser.mui).invite(matrixRoomId, invitedUserMatrixId);
geekgonecrazy marked this conversation as resolved.
Show resolved Hide resolved
}

// Add the matrix user to the invited room
addUserToRoom(roomId, invitedUser, user, false);
geekgonecrazy marked this conversation as resolved.
Show resolved Hide resolved

};

export const createRemote = async (u: IUser): Promise<ICreateUserResult> => {
Expand Down