Release 4.3.1 #24108
Merged
Release 4.3.1 #24108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Kevin Aleman <kevin.aleman@rocket.chat>
* [FIX] Enter not working on modal's multiline input * Apply suggestions from code review * simplify if condition Co-authored-by: Tiago Evangelista Pinto <tiago.evangelista@rocket.chat>
…4067) * Fix omnichannel enabled setting not working when creating rooms * Revert changes to translation file * Apply suggestions from code review
* Include Firefox ESR in browserslist * Upgrade `@rocket.chat/fuselage-hooks`
pierre-lehnen-rc
approved these changes
Jan 5, 2022
murtaza98
approved these changes
Jan 5, 2022
There was a problem hiding this comment.
Sidenote: The build seems to be failing due to the change in prettier rules on master & develop. On "master", the line width (printWidth prop to be precise) is set to 100 while on "develop" it is increased to 140, hence some styling builds are failing here. This should get fixed in the next main release when the whole "develop" branch gets merged to master.
sampaiodiego
force-pushed
the
release-4.3.1
branch
from
f4d943f
to
4601830
Compare
thassiov
approved these changes
Jan 5, 2022
sampaiodiego
force-pushed
the
release-4.3.1
branch
from
16ba201
to
7dddc15
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2022-01-04 · 6 🐛 · 1 🔍 · 6 👩💻👨💻Engine versions
12.22.16.14.13.6, 4.0, 4.2, 4.4, 5.01.29.1🐛 Bug fixes
APPS: Action buttons not removed when app is disabled or uninstalled (#24107 by @d-gubert)
Fixes a problem where action buttons registered by any app would not be removed if the app was disabled or uninstalled
APPS: Prevents emails from being sent when apps framework is disabled (#24105 by @d-gubert)
Introduction of new event
IPreEmailSentwas breaking the email function when the Apps-Engine framework was disabled in the administrationEnsure Firefox 91 ESR support (#24096 by @tassoevan)
It:
Adds
Firefox ESRtobrowserslist;Upgrades
@rocket.chat/fuselage-hooksto overcome a bug related to Firefox implementation ofResizeObserverAPI.Enter not working on modal's multi-line input (#23981 by @murtaza98 & @tiagoevanp)
Right now, if we try to press enter for a new line on multi-line modal input... it auto triggers the submit event. This PR fixes this behaviour by not submitting the modal in case the enter was pressed within an input text with multiline expected
Omnichannel Current chats pagination not working (#24039 by @KevLehman & @murtaza98)
Omnichannel enabled setting not working when creating rooms (#24067 by @murtaza98)
🔍 Minor changes
👩💻👨💻 Contributors 😍