Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] GDPR action to forget visitor data on request #24441

Merged
merged 3 commits into from Feb 16, 2022
Merged

[FIX] GDPR action to forget visitor data on request #24441

merged 3 commits into from Feb 16, 2022

Conversation

KevLehman
Copy link
Contributor

@KevLehman KevLehman commented Feb 8, 2022 •
edited

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

  • The issue was present on an old fix that prevented admins/users to remove visitors when they had open rooms. However, this affected GDPR "right to forget". This PR fixes that

@KevLehman KevLehman requested a review from a team February 9, 2022 14:33
murtaza98
murtaza98 previously approved these changes Feb 15, 2022
View reviewed changes
Copy link
Contributor

@murtaza98 murtaza98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@murtaza98 murtaza98 force-pushed the fix/gdpr-remove-user-when-requested branch from be72c51 to 3a06ae2 Compare February 15, 2022 07:10
@murtaza98 murtaza98 merged commit c83a78f into develop Feb 16, 2022
@murtaza98 murtaza98 deleted the fix/gdpr-remove-user-when-requested branch February 16, 2022 04:24
@pierre-lehnen-rc pierre-lehnen-rc mentioned this pull request Mar 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@murtaza98 murtaza98 murtaza98 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@KevLehman @murtaza98