Chore: Improve PR title validation regex #24467
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
I don't know how it happened, but looks like the regex was accepting some invalid titles like for example:
In this case, it should be invalid because the seconds group (
[EE]
) is invalid, but since[IMPROVE]
is valid, the regex has a match and so the title is considered valid.The new regex will validate the second group as well, if present, and allow only the values
[ENTERPRISE]
and[APPS]
.I've used this list of valid and invalid titles to check the regex:
I'm considering having somes tests to make sure the regex works as expected and having a reference to check at some point. wdyt?
Issue(s)
Steps to test or reproduce
Further comments