[FIX] Change NPS Vote identifier + nps index to unique

apps/meteor/app/models/server/raw/BaseRaw.ts

@@ -85,7 +85,9 @@ export class BaseRaw<T, C extends DefaultFields<T> = undefined> implements IBase
 
 		const indexes = this.modelIndexes();
 		if (indexes?.length) {
-			this.col.createIndexes(indexes);
+			this.col.createIndexes(indexes).catch((e) => {
+				console.warn(`Error creating indexes for ${this.name}`, e);
+			});
 		}
 
 		this.preventSetUpdatedAt = options?.preventSetUpdatedAt ?? false;

apps/meteor/app/models/server/raw/NpsVote.ts

@@ -6,7 +6,7 @@ import { BaseRaw, IndexSpecification } from './BaseRaw';
 type T = INpsVote;
 export class NpsVoteRaw extends BaseRaw<T> {
 	modelIndexes(): IndexSpecification[] {
-		return [{ key: { npsId: 1, status: 1, sentAt: 1 } }, { key: { npsId: 1, identifier: 1 } }];
+		return [{ key: { npsId: 1, status: 1, sentAt: 1 } }, { key: { npsId: 1, identifier: 1 }, unique: true }];
 	}
 
 	findNotSentByNpsId(npsId: string, options?: WithoutProjection<FindOneOptions<T>>): Cursor<T> {

apps/meteor/server/startup/migrations/index.ts

@@ -85,4 +85,5 @@ import './v258';
 import './v259';
 import './v260';
 import './v261';
+import './v262';
 import './xrun';

apps/meteor/server/startup/migrations/v262.ts

@@ -0,0 +1,41 @@
+import { MongoInternals } from 'meteor/mongo';
+
+import { addMigration } from '../../lib/migrations';
+
+addMigration({
+	version: 262,
+	async up() {
+		const { mongo } = MongoInternals.defaultRemoteCollectionDriver();
+		const npsVote = mongo.db.collection('rocketchat_nps_vote');
+
+		const duplicated = await npsVote
+			.aggregate([
+				{
+					$group: {
+						_id: { identifier: '$identifier', npsId: '$npsId' },
+						total: { $sum: 1 },
+						firstId: { $first: '$_id' },
+					},
+				},
+				{
+					$match: {
+						total: { $gt: 1 },
+					},
+				},
+			])
+			.toArray(); // since there should not be too much duplicated, it is safe to use .toArray()
+
+		await Promise.all(
+			duplicated.map((record) =>
+				npsVote.deleteMany({
+					_id: { $ne: record.firstId },
+					identifier: record._id.identifier,
+					npsId: record._id.npsId,
+				}),
+			),
+		);
+
+		await npsVote.dropIndex('npsId_1_identifier_1');
+		await npsVote.createIndex({ npsId: 1, identifier: 1 }, { unique: true });
+	},
+});