Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: [VideoConference] Callee client behaves improperly when accepting a call from someone who lost the connection #26101

Merged
merged 3 commits into from
Jul 4, 2022

Conversation

pierre-lehnen-rc
Copy link
Contributor

@pierre-lehnen-rc pierre-lehnen-rc commented Jul 1, 2022

Proposed changes (including videos or screenshots)

If the caller loses connection and the callee accepts the call anyway, the client will wait for five seconds for confirmation that they can join the call. This PR improves the UI behavior during those five seconds.

Issue(s)

Steps to test or reproduce

Further comments

@pierre-lehnen-rc pierre-lehnen-rc requested a review from a team as a code owner July 1, 2022 21:55
@pierre-lehnen-rc pierre-lehnen-rc changed the title [IMPROVE] Changed the way the callee client handles call acceptance. [IMPROVE] [VideoConference] Changed the way the callee client handles call acceptance. Jul 1, 2022
@pierre-lehnen-rc pierre-lehnen-rc changed the title [IMPROVE] [VideoConference] Changed the way the callee client handles call acceptance. Regression: [VideoConference] Callee client behaves improperly when accepting a call from someone who lost the connection Jul 1, 2022
@pierre-lehnen-rc pierre-lehnen-rc added this to the 5.0.0 milestone Jul 1, 2022
@ggazzo ggazzo added stat: QA skipped stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Jul 4, 2022
@kodiakhq kodiakhq bot merged commit b5a9c59 into develop Jul 4, 2022
@kodiakhq kodiakhq bot deleted the improve/handling-of-call-acceptance branch July 4, 2022 20:16
weslley543 pushed a commit that referenced this pull request Jul 5, 2022
…ccepting a call from someone who lost the connection (#26101)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants