Regression: Fix marketplace releases tab crash bug #26162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed a bug where RC would crash because the marketplace releases tab was trying to display undefined data from manually installed apps.
graywolf336
reviewed
Jul 7, 2022
Makes sense, when I did this logic I believed both informations were mandatory. Will adapt it in a sec. |
Refactored the policies section to allow situations where only the tosLink or privacyLink where received from the back-end.
graywolf336
previously approved these changes
Jul 13, 2022
geekgonecrazy
previously approved these changes
Jul 13, 2022
…tChat/Rocket.Chat into fix/marketplace-releases-tab-crash
ggazzo
requested changes
Jul 13, 2022
Added missing translation keys for the Terms of use and Privacy Policy links on the AppSecurity component.
Fixed a problem where the lift of the useEndpointData from AppReleases to AppDetailsPage caused an unwanted toast to be fired. The hook was lifted to solve the releases tab appearing for manually installed apps, now it uses the marketplace field of the manually installed app to do this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Fixed a bug where RC would crash because the marketplace releases tab was trying to display undefined data from manually installed apps.
Demo gif:
Issue(s)
Steps to test or reproduce
Further comments