Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression: REST API calls at Engagement Dashboard #26235

Merged
merged 1 commit into from
Jul 15, 2022
Merged

Regression: REST API calls at Engagement Dashboard #26235

merged 1 commit into from
Jul 15, 2022

Conversation

tassoevan
Copy link
Contributor

Proposed changes (including videos or screenshots)

Parameters for GET requests are not serialized as for other methods, therefore sending Date objects is not viable due to the way Date.prototype.toString works. This PR uses Date.prototype.toISOString explicitly to serialize dates.

Issue(s)

Steps to test or reproduce

Further comments

@tassoevan tassoevan added this to the 5.0.0 milestone Jul 12, 2022
@tassoevan tassoevan marked this pull request as ready for review July 12, 2022 18:02
@tassoevan tassoevan requested a review from ggazzo July 12, 2022 19:03
@ggazzo ggazzo added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Jul 13, 2022
@sampaiodiego sampaiodiego merged commit 3987360 into develop Jul 15, 2022
@sampaiodiego sampaiodiego deleted the regression/engagement-dashboard-requests branch July 15, 2022 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggazzo ggazzo ggazzo approved these changes

Assignees
No one assigned
Labels
stat: QA tested stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tassoevan @ggazzo @sampaiodiego @gabrielaolson