Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Adjusted priority to run canned responses replace before new parser #26298

Merged
merged 1 commit into from
Jul 19, 2022

Conversation

aleksandernsilva
Copy link
Contributor

Proposed changes (including videos or screenshots)

Canned responses placeholders were not being replaced properly after we changed to the new md parser.
This fix changes the priority so that the canned responses replace logic runs before the parser, thus bringing back this functionality.

Before:
Screen Shot 2022-07-18 at 19 25 07

After:
Screen Shot 2022-07-18 at 19 26 09

Issue(s)

Steps to test or reproduce

Further comments

@ggazzo ggazzo added the stat: ready to merge PR tested and approved waiting for merge label Jul 19, 2022
@ggazzo ggazzo merged commit 55b2617 into develop Jul 19, 2022
@ggazzo ggazzo deleted the fix/canned-responses-on-new-parser branch July 19, 2022 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA tested stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants