Regression: fix directory endpoint not listing teams
#26310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlosrodrigues94
force-pushed
the
FIX/teams_list
branch
from
fa7bd90
to
ac72201
Compare
matheusbsilva137
changed the title
directory endpoint not listing teams
matheusbsilva137
requested changes
Jul 20, 2022
matheusbsilva137
requested changes
Jul 20, 2022
matheusbsilva137
previously approved these changes
Jul 20, 2022
ggazzo
requested changes
Jul 20, 2022
| }); | ||
| const getChannelsCountForTeam = mem( | ||
| (teamId) => { | ||
| return Rooms.findByTeamId(teamId, { projection: { _id: 1 } }); |
There was a problem hiding this comment.
as far as i understand this returns a cursor, cursors are VERY FAST, they only generates a object structure, no cache needed
| const teams = []; | ||
|
|
||
| for await (const room of rooms) { | ||
| const roomsCount = await getChannelsCountForTeam(room.teamId).count(); |
There was a problem hiding this comment.
this count generates a call to the db, it could be cached
matheusbsilva137
approved these changes
Jul 20, 2022
sampaiodiego
approved these changes
Jul 20, 2022
|
that endpoint is missing a test to validate the return of teams.. can either of you @carlosrodrigues94 or @matheusbsilva137 add a test to it pls? |
gabriellsh
added a commit
that referenced
this pull request
Jul 26, 2022
* 'develop' of github.com:RocketChat/Rocket.Chat: (294 commits) Chore: Convert UserCardWithData to ts (#26192) Chore: cleanup startup of test and put wizard in setup function (#26306) Chore: Convert AccountPreferencesPage to ts (#26096) [FIX] Missing bio field UI validation (#26345) Chore: Remove square prop from IconButton (#26343) Chore: Rewrite VerticalBarOldActions to TS (#26277) Chore: Replace direct multiple icon (#26342) Chore: Upgrade ESLint (#26132) Chore: convert autotranslate to ts (#25953) Chore: Change some places still using fields to projection (#26308) Bump version to 5.1.0-develop Bump version to 5.0.0 Bump version to 5.0.0-rc.12 Regression: Livechat not rendering UiKit messages with action buttons (#26327) Chore: bump fuselage packages (#26325) Chore: Update useSidebarPalette selectors (#26322) Regression: Fix get myself user data (#26328) Bump version to 5.0.0-rc.11 Bump version to 4.8.2 Regression: fix `directory` endpoint not listing teams (#26310) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments