Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Add end-to-end tests to teams listing in the directory endpoint #26347

Merged
merged 3 commits into from Aug 2, 2022
Merged

Chore: Add end-to-end tests to teams listing in the directory endpoint #26347

merged 3 commits into from Aug 2, 2022

Conversation

carlosrodrigues94
Copy link
Contributor

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@carlosrodrigues94 carlosrodrigues94 requested a review from a team as a code owner July 22, 2022 19:37
@sampaiodiego
Copy link
Member

@carlosrodrigues94 did you check the CI result? it seems to be failing in the new test you just created =)

@carlosrodrigues94
Copy link
Contributor Author

@carlosrodrigues94 did you check the CI result? it seems to be failing in the new test you just created =)

fixed.

@matheusbsilva137 matheusbsilva137 changed the title [IMPROVE] add test for teams list [IMPROVE] Add end-to-end tests to teams listing in the directory endpoint Jul 28, 2022
@codecov
Copy link

codecov bot commented Aug 2, 2022

Codecov Report

Merging #26347 (94b805d) into develop (355819e) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #26347      +/-   ##
===========================================
- Coverage    39.05%   39.05%   -0.01%     
===========================================
  Files          748      748              
  Lines        18647    18647              
  Branches      1424     1424              
===========================================
- Hits          7283     7282       -1     
- Misses       11141    11143       +2     
+ Partials       223      222       -1
Flag Coverage Δ
e2e 39.05% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...app/ui-message/client/popup/messagePopupChannel.js 50.00% <0.00%> (-50.00%) ⬇️
...views/room/MessageList/lib/isMessageFirstUnread.ts 50.00% <0.00%> (-16.67%) ⬇️
apps/meteor/client/lib/meteorCallWrapper.ts 96.42% <0.00%> (-3.58%) ⬇️
apps/meteor/app/ui-login/client/login/form.js 73.20% <0.00%> (-0.66%) ⬇️
...ached-collection/client/models/CachedCollection.js 85.41% <0.00%> (-0.53%) ⬇️
...teor/app/ui-utils/client/lib/RoomHistoryManager.js 51.44% <0.00%> (-0.49%) ⬇️
apps/meteor/app/ui/client/views/app/room.js 49.59% <0.00%> (-0.21%) ⬇️
apps/meteor/app/ui-utils/client/lib/RoomManager.js 76.00% <0.00%> (+1.14%) ⬆️
...r/client/startup/notifications/usersNameChanged.ts 100.00% <0.00%> (+66.66%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us.

@sampaiodiego sampaiodiego changed the title [IMPROVE] Add end-to-end tests to teams listing in the directory endpoint Chore: Add end-to-end tests to teams listing in the directory endpoint Aug 2, 2022
@carlosrodrigues94
Copy link
Contributor Author

Codecov Report

Merging #26347 (94b805d) into develop (355819e) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #26347      +/-   ##
===========================================
- Coverage    39.05%   39.05%   -0.01%     
===========================================
  Files          748      748              
  Lines        18647    18647              
  Branches      1424     1424              
===========================================
- Hits          7283     7282       -1     
- Misses       11141    11143       +2     
+ Partials       223      222       -1

Flag Coverage Δ
e2e 39.05% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files Coverage Δ
...app/ui-message/client/popup/messagePopupChannel.js 50.00% <0.00%> (-50.00%) ⬇️
...views/room/MessageList/lib/isMessageFirstUnread.ts 50.00% <0.00%> (-16.67%) ⬇️
apps/meteor/client/lib/meteorCallWrapper.ts 96.42% <0.00%> (-3.58%) ⬇️
apps/meteor/app/ui-login/client/login/form.js 73.20% <0.00%> (-0.66%) ⬇️
...ached-collection/client/models/CachedCollection.js 85.41% <0.00%> (-0.53%) ⬇️
...teor/app/ui-utils/client/lib/RoomHistoryManager.js 51.44% <0.00%> (-0.49%) ⬇️
apps/meteor/app/ui/client/views/app/room.js 49.59% <0.00%> (-0.21%) ⬇️
apps/meteor/app/ui-utils/client/lib/RoomManager.js 76.00% <0.00%> (+1.14%) ⬆️
...r/client/startup/notifications/usersNameChanged.ts 100.00% <0.00%> (+66.66%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us.

updating asserts to ensure coverage

@ggazzo ggazzo added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Aug 2, 2022
@kodiakhq kodiakhq bot merged commit f00b83e into develop Aug 2, 2022
@kodiakhq kodiakhq bot deleted the improve/add_test_for_teams_list branch August 2, 2022 19:58
carlosrodrigues94 added a commit that referenced this pull request Aug 3, 2022
@carlosrodrigues94
Chore: Add end-to-end tests to teams listing in the directory endpo…
e85dfe8 
…int (#26347)
gabriellsh added a commit that referenced this pull request Aug 4, 2022
@gabriellsh
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into impr…
2dea96d 
…ove-e2ee-threadlist

* 'develop' of github.com:RocketChat/Rocket.Chat: (200 commits)
  [FIX] Undefined MediaDevices error on HTTP (#26396)
  Chore: Codecov threshold (#26477)
  Chore: Tests intermitences (#26464)
  [FIX] Don't give errors on outbound voip call Request Terminated (#26373)
  Chore: Use Docker compose on CI (#26437)
  [FIX] DialPad call button from end to center (#26459)
  Chore: Parallelize e2e tests (#26390)
  [IMPROVE] use enter key to call using DialPad (#26454)
  Chore: Accounts/token to TS (#26434)
  Chore: Purge some unused modules (#26447)
  i18n: Language update from LingoHub 🤖 on 2022-08-01Z (#26429)
  Chore: Add end-to-end tests to teams listing in the `directory` endpoint (#26347)
  Chore: Cache playwright (#26432)
  [FIX] Empty results on `im.list` endpoint (#26438)
  [IMPROVE] Upgrade nivo and React Query (#26338)
  Chore: Upgrade Fuselage packages to next dist-tag (#26435)
  Chore: Omnichannel endpoints e2e tests (#26376)
  Chore: Refactor UserInfo to typescript (#26323)
  Chore: Rewrite Location modal to React (#26196)
  Chore: Rewrite SaveToWebdav Modal to React Component (#24365)
  ...
gabriellsh added a commit that referenced this pull request Aug 8, 2022
@gabriellsh
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into new/…
a213b58 
…homepage

* 'develop' of github.com:RocketChat/Rocket.Chat: (39 commits)
  Chore: ESLint warnings (#26504)
  Chore: Remove settings Fibers usage (#26465)
  Chore: Refactor create-target-channel util (#26493)
  Chore: useEndpointData deprecation (#26494)
  [NEW] Surface featured apps endpoint  (#26416)
  [FIX] Request at least one field in the payload of `/v1/users.setStatus` (#26490)
  Chore: Exit process on `unhandledRejection` on CI (#26467)
  [FIX] Clear push token on save user password (#26466)
  [FIX] Undefined MediaDevices error on HTTP (#26396)
  Chore: Codecov threshold (#26477)
  Chore: Tests intermitences (#26464)
  [FIX] Don't give errors on outbound voip call Request Terminated (#26373)
  Chore: Use Docker compose on CI (#26437)
  [FIX] DialPad call button from end to center (#26459)
  Chore: Parallelize e2e tests (#26390)
  [IMPROVE] use enter key to call using DialPad (#26454)
  Chore: Accounts/token to TS (#26434)
  Chore: Purge some unused modules (#26447)
  i18n: Language update from LingoHub 🤖 on 2022-08-01Z (#26429)
  Chore: Add end-to-end tests to teams listing in the `directory` endpoint (#26347)
  ...
@murtaza98 murtaza98 mentioned this pull request Sep 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sampaiodiego sampaiodiego sampaiodiego approved these changes

@matheusbsilva137 matheusbsilva137 matheusbsilva137 left review comments

Assignees
No one assigned
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@carlosrodrigues94 @sampaiodiego @matheusbsilva137 @ggazzo