Chore: Convert AutoCompleteAgent to TS #26370
Open
+68
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
debdutdeb
requested changes
Jul 27, 2022
Co-authored-by: Eduardo Afonso <oeduardoafonso@gmail.com>
RcleydsonR
force-pushed
the
convert-autoCompleteAgent-to-ts
branch
from
cb4a9af
to
4f1e8a5
Compare
aleksandernsilva
previously approved these changes
Aug 9, 2022
|
Hey @aleksandernsilva, thx for your review. |
|
Should this close #26565 ? |
No @KevLehman, #26565 is another component. There's a review at #26565, but I'm trying to get some free time to fix it. |
|
Ohh! My bad, I just read the "AutoComplete" part. Thanks!! BTW, noticing our linter is complaining about some Prettier suggestions. Can you manage them? To run our linter on local, you can run from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
This pull request converts the file
apps/meteor/client/components/AutoCompleteAgentfrom Javascript to Typescript.Issue(s)
Steps to test or reproduce
Further comments