Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: refactor/room #26675

Merged
merged 44 commits into from Sep 9, 2022
Merged

Chore: refactor/room #26675

merged 44 commits into from Sep 9, 2022

Conversation

tassoevan
Copy link
Contributor

@tassoevan tassoevan commented Aug 25, 2022

Proposed changes (including videos or screenshots)

Replaces room Blaze template with React components.

Issue(s)

Steps to test or reproduce

Further comments

The effects and some of the state management need more work.

@codecov
Copy link

codecov bot commented Aug 25, 2022

Codecov Report

Merging #26675 (c826661) into develop (d30e08e) will increase coverage by 0.04%.
The diff coverage is 43.58%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #26675      +/-   ##
===========================================
+ Coverage    40.54%   40.58%   +0.04%     
===========================================
  Files          799      792       -7     
  Lines        18289    17913     -376     
  Branches      1959     1927      -32     
===========================================
- Hits          7415     7270     -145     
+ Misses       10578    10349     -229     
+ Partials       296      294       -2     
Flag Coverage Δ
e2e 40.58% <43.58%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo marked this pull request as ready for review September 6, 2022 20:34
@ggazzo ggazzo requested review from a team as code owners September 6, 2022 20:34
@ggazzo ggazzo merged commit 3b35f8b into develop Sep 9, 2022
@ggazzo ggazzo deleted the refactor/room branch September 9, 2022 21:40
@tassoevan tassoevan mentioned this pull request Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants