New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: refactor/room
#26675
Merged
Merged
Chore: refactor/room
#26675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #26675 +/- ##
===========================================
+ Coverage 40.54% 40.58% +0.04%
===========================================
Files 799 792 -7
Lines 18289 17913 -376
Branches 1959 1927 -32
===========================================
- Hits 7415 7270 -145
+ Misses 10578 10349 -229
+ Partials 296 294 -2
Flags with carried forward coverage won't be shown. Click here to find out more. |
…/Rocket.Chat into refactor/room
tassoevan
force-pushed
the
refactor/room
branch
from
August 30, 2022 18:26
0e38fea
to
a5c6169
Compare
This reverts commit a5c6169.
ggazzo
approved these changes
Sep 6, 2022
tiagoevanp
approved these changes
Sep 9, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Replaces
room
Blaze template with React components.Issue(s)
Steps to test or reproduce
Further comments
The effects and some of the state management need more work.