Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Refactoring Not Found pages #26715

Merged
merged 12 commits into from Mar 27, 2023
Merged

chore: Refactoring Not Found pages #26715

merged 12 commits into from Mar 27, 2023

Conversation

guijun13
Copy link
Contributor

@guijun13 guijun13 commented Aug 26, 2022 •
edited by dougfabris

Proposed changes (including videos or screenshots)

Create NotFoundState component to use on NotFoundPage and RoomNotFound

Issue(s)

Steps to test or reproduce

Further comments

@codecov
Copy link

codecov bot commented Aug 27, 2022 •
edited

Codecov Report

Merging #26715 (c8d5e77) into develop (ead5f09) will decrease coverage by 1.12%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #26715      +/-   ##
===========================================
- Coverage    40.24%   39.12%   -1.12%     
===========================================
  Files          732      689      -43     
  Lines        14447    13686     -761     
  Branches      2093     2044      -49     
===========================================
- Hits          5814     5355     -459     
+ Misses        8348     8067     -281     
+ Partials       285      264      -21
Flag Coverage Δ
e2e 39.09% <ø> (-1.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo added this to the 6.0.0-pre milestone Nov 24, 2022
@guijun13 guijun13 removed the eng day label Jan 9, 2023
@guijun13 guijun13 marked this pull request as ready for review January 9, 2023 16:33
@guijun13 guijun13 requested a review from a team as a code owner January 9, 2023 16:33
@dougfabris dougfabris changed the title Chore: Refactoring not found pages Chore: Refactoring Not Found pages Mar 1, 2023
@dougfabris dougfabris modified the milestones: 6.0.0-prep, 6.1.0 Mar 1, 2023
@casalsgh casalsgh added the stat: ready to merge PR tested and approved waiting for merge label Mar 23, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Mar 23, 2023
@guijun13 guijun13 changed the title Chore: Refactoring Not Found pages chore: Refactoring Not Found pages Mar 27, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Mar 27, 2023
@kodiakhq kodiakhq bot merged commit 2dbe359 into develop Mar 27, 2023
35 of 36 checks passed
@kodiakhq kodiakhq bot deleted the refactor/not-found-page branch March 27, 2023 17:03
@sampaiodiego
Copy link
Member

hey guys, just a reminder that we have the refactor type for PR titles.. so chore: Refactoring doesn't make much sense, it should be refactor: Something instead 👍

@casalsgh casalsgh modified the milestones: 6.1.0, 6.2.0 Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougfabris dougfabris dougfabris approved these changes

Assignees
No one assigned
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Milestone
6.2.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@guijun13 @sampaiodiego @dougfabris @ggazzo @casalsgh