Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Remove section and replace icon on administration kebab menu #26986

Merged
merged 4 commits into from Oct 4, 2022

Conversation

filipemarins
Copy link
Contributor

@filipemarins filipemarins commented Sep 30, 2022

Proposed changes (including videos or screenshots)

Issue(s)

TC-144

Steps to test or reproduce

Further comments

Update kebab menu options.

  • Remove settings session
  • Remove manage words on the menu
  • Replace the marketplace icon

Screen Shot 2022-09-30 at 11 19 01

@codecov
Copy link

codecov bot commented Sep 30, 2022

Codecov Report

Merging #26986 (87be35c) into develop (3c96bc7) will decrease coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #26986      +/-   ##
===========================================
- Coverage    41.01%   40.91%   -0.10%     
===========================================
  Files          804      804              
  Lines        17923    17923              
  Branches      1960     1960              
===========================================
- Hits          7351     7334      -17     
- Misses       10272    10290      +18     
+ Partials       300      299       -1     
Flag Coverage Δ
e2e 40.91% <ø> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@engelgabriel engelgabriel added this to the 5.2.0 milestone Sep 30, 2022
Copy link
Member

@gabriellsh gabriellsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

ggazzo
ggazzo previously requested changes Oct 4, 2022
Copy link
Member

@ggazzo ggazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong title and missing explanation

@filipemarins filipemarins changed the title [FIX] update kebab menu [FIX] Remove section and replace icon on administration kebab menu Oct 4, 2022
@ggazzo ggazzo changed the title [FIX] Remove section and replace icon on administration kebab menu Regression: Remove section and replace icon on administration kebab menu Oct 4, 2022
@tassoevan tassoevan merged commit 175d6a1 into develop Oct 4, 2022
@tassoevan tassoevan deleted the update/kebab branch October 4, 2022 15:40
@tassoevan tassoevan mentioned this pull request Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants