Regression: Handle undefined values on useReactiveQuery's query function
#26988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #26988 +/- ##
===========================================
- Coverage 41.02% 40.06% -0.96%
===========================================
Files 801 829 +28
Lines 17908 18376 +468
Branches 1961 2019 +58
===========================================
+ Hits 7346 7363 +17
- Misses 10264 10714 +450
- Partials 298 299 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
tassoevan
force-pushed
the
regression/reactive-queries
branch
from
06bd852
to
9d7ad27
Compare
ggazzo
approved these changes
Oct 4, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
According to https://tanstack.com/query/v4/docs/reference/useQuery, the query function must not return
undefinedvalues, a quirk that we've been ignoring.Issue(s)
Steps to test or reproduce
Further comments
OC-259