New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: break LDAP manager into smaller pieces to improve unit tests #26994
Conversation
Co-authored-by: Diego Sampaio <chinello@gmail.com>
Codecov Report
@@ Coverage Diff @@
## develop #26994 +/- ##
===========================================
+ Coverage 40.13% 41.03% +0.90%
===========================================
Files 828 802 -26
Lines 18287 17810 -477
Branches 2020 1961 -59
===========================================
- Hits 7339 7309 -30
+ Misses 10654 10207 -447
Partials 294 294
Flags with carried forward coverage won't be shown. Click here to find out more. |
Co-authored-by: Pierre Lehnen <55164754+pierre-lehnen-rc@users.noreply.github.com>
import { Meteor } from 'meteor/meteor'; | ||
import { Logger } from '../../../server/lib/logger/Logger'; | ||
|
||
let logger; | ||
|
||
if (Meteor.isServer) { | ||
const { Logger } = require('../../../server/lib/logger/Logger'); | ||
logger = new Logger('TemplateVarHandler'); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a problem worth reverting for but this file should've been moved to a "server" folder now that it only works in the server.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments