Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Cannot edit messages in some environments. #27023

Merged
merged 1 commit into from Oct 7, 2022

Conversation

gabriellsh
Copy link
Member

Proposed changes (including videos or screenshots)

An empty $unset object was being used and causes exceptions in some mongo versions.

Issue(s)

Steps to test or reproduce

Further comments

@ggazzo ggazzo added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Oct 6, 2022
@gabriellsh gabriellsh added stat: needs QA and removed stat: QA skipped stat: ready to merge PR tested and approved waiting for merge labels Oct 6, 2022
@codecov
Copy link

codecov bot commented Oct 6, 2022

Codecov Report

Merging #27023 (63e2fe3) into develop (4afcbf6) will decrease coverage by 0.28%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #27023      +/-   ##
===========================================
- Coverage    41.06%   40.78%   -0.29%     
===========================================
  Files          802      802              
  Lines        17810    17810              
  Branches      1961     1961              
===========================================
- Hits          7314     7264      -50     
- Misses       10202    10251      +49     
- Partials       294      295       +1     
Flag Coverage Δ
e2e 40.78% <ø> (-0.29%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@sampaiodiego sampaiodiego added this to the 5.2.0 milestone Oct 7, 2022
@sampaiodiego sampaiodiego merged commit fc71f80 into develop Oct 7, 2022
@sampaiodiego sampaiodiego deleted the fix/editMessage branch October 7, 2022 12:35
@tassoevan tassoevan mentioned this pull request Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants