New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BREAK] Migrate current priorities endpoints to SLAs #27104
Merged
KevLehman
merged 15 commits into
feature/omnichannel-priorities
from
new/update-endpoints-with-sla
Nov 9, 2022
Merged
[BREAK] Migrate current priorities endpoints to SLAs #27104
KevLehman
merged 15 commits into
feature/omnichannel-priorities
from
new/update-endpoints-with-sla
Nov 9, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cauefcr
changed the title
[BREAK][IMPROVE] Migrated current priorities endpoints to SLAs
[BREAK] Migrate current priorities endpoints to SLAs
Oct 19, 2022
murtaza98
previously approved these changes
Oct 20, 2022
KevLehman
requested changes
Oct 20, 2022
apps/meteor/ee/app/livechat-enterprise/server/lib/LivechatEnterprise.js
Outdated
Show resolved
Hide resolved
apps/meteor/ee/app/livechat-enterprise/server/lib/LivechatEnterprise.js
Outdated
Show resolved
Hide resolved
aleksandernsilva
requested changes
Oct 21, 2022
apps/meteor/ee/app/livechat-enterprise/server/hooks/onSaveVisitorInfo.js
Outdated
Show resolved
Hide resolved
apps/meteor/ee/client/omnichannel/priorities/PrioritiesRoute.js
Outdated
Show resolved
Hide resolved
Can you link which PRs this has included? So we can close the other ones to avoid conflicts 👀 . (Apart from that, everything looks fine i think ) |
cauefcr
force-pushed
the
new/update-endpoints-with-sla
branch
from
November 3, 2022 16:16
067ba6e
to
f631934
Compare
cauefcr
changed the title
[BREAK] Migrate current priorities endpoints to SLAs
[BREAK] Migrate current priorities endpoints to SLAs, create base for the new priorities
Nov 3, 2022
based on this PR #27093 |
aleksandernsilva
requested changes
Nov 3, 2022
apps/meteor/ee/app/livechat-enterprise/server/lib/LivechatEnterprise.js
Outdated
Show resolved
Hide resolved
apps/meteor/ee/app/livechat-enterprise/server/api/lib/priorities.ts
Outdated
Show resolved
Hide resolved
cauefcr
force-pushed
the
new/update-endpoints-with-sla
branch
from
November 3, 2022 19:34
769c07f
to
ddc41fb
Compare
aleksandernsilva
approved these changes
Nov 3, 2022
KevLehman
requested changes
Nov 3, 2022
apps/meteor/ee/app/livechat-enterprise/server/api/lib/priorities.ts
Outdated
Show resolved
Hide resolved
apps/meteor/ee/app/livechat-enterprise/server/api/priorities.ts
Outdated
Show resolved
Hide resolved
apps/meteor/ee/app/livechat-enterprise/server/api/priorities.ts
Outdated
Show resolved
Hide resolved
apps/meteor/ee/app/livechat-enterprise/server/hooks/beforeNewRoom.js
Outdated
Show resolved
Hide resolved
apps/meteor/ee/app/livechat-enterprise/server/lib/LivechatEnterprise.js
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## feature/omnichannel-priorities #27104 +/- ##
==================================================================
+ Coverage 40.98% 41.02% +0.03%
==================================================================
Files 802 802
Lines 17819 17810 -9
Branches 1972 1961 -11
==================================================================
+ Hits 7304 7307 +3
+ Misses 10223 10208 -15
- Partials 292 295 +3
Flags with carried forward coverage won't be shown. Click here to find out more. |
KevLehman
requested changes
Nov 8, 2022
apps/meteor/ee/app/livechat-enterprise/client/views/livechatSideNavItems.js
Show resolved
Hide resolved
apps/meteor/ee/app/livechat-enterprise/client/views/livechatSideNavItems.js
Outdated
Show resolved
Hide resolved
apps/meteor/ee/app/livechat-enterprise/server/lib/LivechatEnterprise.js
Outdated
Show resolved
Hide resolved
KevLehman
approved these changes
Nov 9, 2022
KevLehman
changed the title
[BREAK] Migrate current priorities endpoints to SLAs, create base for the new priorities
[BREAK] Migrate current priorities endpoints to SLAs
Nov 9, 2022
dionisio-bot
bot
added
stat: ready to merge
PR tested and approved waiting for merge
and removed
stat: needs QA
labels
Nov 11, 2022
Harmeet221
removed
the
stat: ready to merge
PR tested and approved waiting for merge
label
Nov 11, 2022
dionisio-bot
bot
added
the
stat: ready to merge
PR tested and approved waiting for merge
label
Nov 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
becomes
and the new priority endpoints are:
Name changes, migration and deprecation of old name, as it'll be used in the future, similar changes done to functions, models, tests and types.
Issue(s)
Steps to test or reproduce
Further comments
OC-291
OC-292
OC-293
OC-294
OC-390