Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BREAK] Migrate current priorities endpoints to SLAs #27104

Merged

Conversation

cauefcr
Copy link
Contributor

@cauefcr cauefcr commented Oct 19, 2022

Proposed changes (including videos or screenshots)

'/v1/livechat/priorities': {
    GET: (params: LivechatPrioritiesProps) => PaginatedResult<{ priorities: ILivechatPriority[] }>;
};

'/v1/livechat/priorities/:priorityId': {
    GET: () => ILivechatPriority;
};

becomes

'/v1/livechat/sla': {
    GET: (params: LivechatPrioritiesProps) => PaginatedResult<{ sla: IOmnichannelServiceLevelAgreements[] }>;
};

'/v1/livechat/sla/:slaId': {
    GET: () => IOmnichannelServiceLevelAgreements;
};

and the new priority endpoints are:

'/v1/livechat/priorities': {
    GET: (params: LivechatPrioritiesProps) => PaginatedResult<{ priorities: ILivechatPriority[] }>;
};

'/v1/livechat/priority/:priorityId': {
    GET: () => ILivechatPriority | void;
};

'/v1/livechat/priority': {
    POST: (params: ILivechatPriorityData) => ILivechatPriority | void;
};

Name changes, migration and deprecation of old name, as it'll be used in the future, similar changes done to functions, models, tests and types.

Issue(s)

Steps to test or reproduce

Further comments

OC-291
OC-292
OC-293
OC-294
OC-390

@cauefcr cauefcr changed the title [BREAK][IMPROVE] Migrated current priorities endpoints to SLAs [BREAK] Migrate current priorities endpoints to SLAs Oct 19, 2022
@cauefcr cauefcr marked this pull request as ready for review October 19, 2022 20:48
@cauefcr cauefcr requested review from a team as code owners October 19, 2022 20:48
murtaza98
murtaza98 previously approved these changes Oct 20, 2022
@KevLehman
Copy link
Contributor

Can you link which PRs this has included? So we can close the other ones to avoid conflicts 👀 .

(Apart from that, everything looks fine i think :trollface: )

@cauefcr cauefcr force-pushed the new/update-endpoints-with-sla branch from 067ba6e to f631934 Compare November 3, 2022 16:16
@cauefcr cauefcr changed the title [BREAK] Migrate current priorities endpoints to SLAs [BREAK] Migrate current priorities endpoints to SLAs, create base for the new priorities Nov 3, 2022
@cauefcr
Copy link
Contributor Author

cauefcr commented Nov 3, 2022

based on this PR #27093

@cauefcr cauefcr force-pushed the new/update-endpoints-with-sla branch from 769c07f to ddc41fb Compare November 3, 2022 19:34
@cauefcr cauefcr dismissed murtaza98’s stale review November 3, 2022 19:37

too many changes after approval

@codecov
Copy link

codecov bot commented Nov 4, 2022

Codecov Report

Merging #27104 (b2501e2) into feature/omnichannel-priorities (80fcc59) will increase coverage by 0.03%.
The diff coverage is 33.33%.

Impacted file tree graph

@@                        Coverage Diff                         @@
##           feature/omnichannel-priorities   #27104      +/-   ##
==================================================================
+ Coverage                           40.98%   41.02%   +0.03%     
==================================================================
  Files                                 802      802              
  Lines                               17819    17810       -9     
  Branches                             1972     1961      -11     
==================================================================
+ Hits                                 7304     7307       +3     
+ Misses                              10223    10208      -15     
- Partials                              292      295       +3     
Flag Coverage Δ
e2e 41.02% <33.33%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@KevLehman KevLehman changed the title [BREAK] Migrate current priorities endpoints to SLAs, create base for the new priorities [BREAK] Migrate current priorities endpoints to SLAs Nov 9, 2022
@KevLehman KevLehman merged commit 24edeab into feature/omnichannel-priorities Nov 9, 2022
@KevLehman KevLehman deleted the new/update-endpoints-with-sla branch November 9, 2022 21:43
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Nov 11, 2022
@Harmeet221 Harmeet221 removed the stat: ready to merge PR tested and approved waiting for merge label Nov 11, 2022
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA tested stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants