Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Allow multiple remplacement of {username} on external avatar url #27360

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

ralmn
Copy link

@ralmn ralmn commented Nov 25, 2022

Proposed changes (including videos or screenshots)

Allow multiple remplacement of {username} on external avatar url

Issue(s)

Steps to test or reproduce

Further comments

@ralmn ralmn requested a review from a team as a code owner November 25, 2022 16:16
@CLAassistant
Copy link

CLAassistant commented Nov 25, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Mathieu HIREL seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@ggazzo
Copy link
Member

ggazzo commented Nov 25, 2022

why this is a fix?

@ralmn
Copy link
Author

ralmn commented Nov 25, 2022

Our webservice to retrieve the photos of our employees asks twice for the username in parameter which is currently not possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants