[IMPROVE] Require acceptance when setting new E2E Encryption key for another user #27556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodrigok
changed the title
Codecov Report
@@ Coverage Diff @@
## develop #27556 +/- ##
===========================================
+ Coverage 41.97% 42.01% +0.04%
===========================================
Files 841 841
Lines 17706 17716 +10
Branches 1996 1998 +2
===========================================
+ Hits 7432 7444 +12
Misses 10016 10016
+ Partials 258 256 -2
Flags with carried forward coverage won't be shown. Click here to find out more. |
rodrigok
force-pushed
the
e2ee-key-accept
branch
from
fa5a6c2
to
fb5daa7
Compare
10 tasks
diegolmello
reviewed
Dec 21, 2022
# Conflicts: # apps/meteor/app/e2e/client/rocketchat.e2e.ts
diegolmello
previously approved these changes
Jan 4, 2023
dionisio-bot
bot
added
stat: ready to merge
LevyCosta
removed
the
stat: ready to merge
dionisio-bot
bot
added
the
stat: ready to merge
sampaiodiego
approved these changes
Jan 10, 2023
tassoevan
approved these changes
Jan 13, 2023
gabriellsh
added a commit
that referenced
this pull request
Jan 16, 2023
…ixSearch * 'develop' of github.com:RocketChat/Rocket.Chat: Chore: Show different labels based on the call originator on direct calls (#27729) Chore: Change bundle tags color and refactor app details page header styles (#27293) [FIX] Auto Translate not working on new message template (#27317) Chore: Custom Sounds Empty State (#27632) [IMPROVE] Require acceptance when setting new E2E Encryption key for another user (#27556) Regression: Broken room and message composer events (#27754) [FIX] Missing placeholders from encrypted channel preview messages now with expected behavior (#27699) [IMPROVE] SAML and OAuth role sync to support id and name (#27405) Chore: add e2e test coverage for Video Conference (#27075) Chore: Invites Empty State (#27631) [FIX] Marketplace app status initially disabled (#27330) Regression: Missing contexts on contextual bar (#27734)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Change the end to end encryption flow to require an acceptance from the user when receiving a new key.
e2e.updateGroupKeyto set the new key to an auxiliary property namedE2ESuggestedKeye2e.acceptSuggestedGroupKeyto be called to accept the suggested key and save it to the final propertyE2EKeye2e.rejectSuggestedGroupKeyto be called to reject the suggested key and clear theE2ESuggestedKeyIssue(s)
Steps to test or reproduce
Further comments