Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Client-side checks for message deletion #27590

Merged
merged 2 commits into from Dec 21, 2022

Conversation

tassoevan
Copy link
Contributor

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@codecov
Copy link

codecov bot commented Dec 20, 2022

Codecov Report

Merging #27590 (fc28393) into develop (af9373f) will decrease coverage by 0.08%.
The diff coverage is 72.72%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #27590      +/-   ##
===========================================
- Coverage    41.97%   41.88%   -0.09%     
===========================================
  Files          822      820       -2     
  Lines        17726    17715      -11     
  Branches      1994     1988       -6     
===========================================
- Hits          7440     7420      -20     
- Misses       10017    10029      +12     
+ Partials       269      266       -3     
Flag Coverage Δ
e2e 41.88% <72.72%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@tassoevan tassoevan changed the title Chore: Review message deletion [FIX] Client-side checks for message deletion Dec 20, 2022
@tassoevan tassoevan marked this pull request as ready for review December 21, 2022 12:08
@tassoevan tassoevan requested a review from a team as a code owner December 21, 2022 12:08
@tassoevan tassoevan changed the title [FIX] Client-side checks for message deletion Regression: Client-side checks for message deletion Dec 21, 2022
@ggazzo ggazzo merged commit fc575e1 into develop Dec 21, 2022
@ggazzo ggazzo deleted the fix/message-deletion branch December 21, 2022 12:25
@sampaiodiego sampaiodiego mentioned this pull request Feb 17, 2023
@sampaiodiego sampaiodiego mentioned this pull request Mar 9, 2023
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants