Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: TwoFactorPass Modals icon misalignment #27591

Merged
merged 1 commit into from Dec 21, 2022

Conversation

dougfabris
Copy link
Member

Proposed changes (including videos or screenshots)

before

Screen Shot 2022-12-20 at 21 05 24

after

Screen Shot 2022-12-20 at 21 04 29

Issue(s)

Steps to test or reproduce

Further comments

@dougfabris dougfabris requested a review from a team as a code owner December 21, 2022 00:05
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Dec 21, 2022
@codecov
Copy link

codecov bot commented Dec 21, 2022

Codecov Report

Merging #27591 (94c1d5c) into develop (af9373f) will decrease coverage by 1.16%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #27591      +/-   ##
===========================================
- Coverage    41.97%   40.80%   -1.17%     
===========================================
  Files          822      849      +27     
  Lines        17726    18245     +519     
  Branches      1994     2069      +75     
===========================================
+ Hits          7440     7445       +5     
- Misses       10017    10535     +518     
+ Partials       269      265       -4     
Flag Coverage Δ
e2e 40.80% <ø> (-1.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo merged commit bdb196c into develop Dec 21, 2022
@ggazzo ggazzo deleted the chore/twoFactor-modal-icon branch December 21, 2022 13:52
gabriellsh added a commit that referenced this pull request Dec 21, 2022
…discussion

* 'develop' of github.com:RocketChat/Rocket.Chat:
  [FIX] E2EE initial banner not showing (#27574)
  Chore: Remove Sidebar from Blaze (#27571)
  Regression: Add tshow to composer params (#27602)
  [FIX] New users aren't mapped to rooms with OAuth groups/channels map (#27000)
  [NEW] New Message Composer (#27566)
  Chore: Fix homepage grid items style (#27527)
  Chore: TwoFactorPass Modals icon misalignment (#27591)
  Chore: Remove old tooltip usage (#26882)
  Bump version to 6.0.0-develop (#27598)
@sampaiodiego sampaiodiego mentioned this pull request Feb 17, 2023
@sampaiodiego sampaiodiego mentioned this pull request Mar 9, 2023
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants