Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] *.files endpoints returning hidden files #27617

Merged
merged 2 commits into from Dec 27, 2022

Conversation

sampaiodiego
Copy link
Member

Proposed changes (including videos or screenshots)

It's now also performing all tests that were previously only running for channels.files endpoint to groups.files and im.files as well.

Issue(s)

Steps to test or reproduce

Further comments

I've changed the index to better support the queries, I'm will create another PR to delete the old indexes.

@sampaiodiego sampaiodiego requested a review from a team as a code owner December 22, 2022 20:06
@codecov
Copy link

codecov bot commented Dec 22, 2022

Codecov Report

Merging #27617 (102f3f6) into develop (be41f2a) will increase coverage by 3.13%.
The diff coverage is 80.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #27617      +/-   ##
===========================================
+ Coverage    40.52%   43.66%   +3.13%     
===========================================
  Files          844      812      -32     
  Lines        17910    17175     -735     
  Branches      1988     1902      -86     
===========================================
+ Hits          7258     7499     +241     
+ Misses       10396     9425     -971     
+ Partials       256      251       -5     
Flag Coverage Δ
e2e 43.66% <80.00%> (+3.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Dec 23, 2022
@ggazzo ggazzo merged commit 22ee46f into develop Dec 27, 2022
@ggazzo ggazzo deleted the fix-returning-hidden-files branch December 27, 2022 02:33
@sampaiodiego sampaiodiego added this to the 5.4.2 milestone Dec 27, 2022
@sampaiodiego sampaiodiego mentioned this pull request Jan 24, 2023
@sampaiodiego sampaiodiego mentioned this pull request Feb 17, 2023
@sampaiodiego sampaiodiego mentioned this pull request Mar 9, 2023
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants