Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Set missing colors #27817

Merged
merged 22 commits into from Feb 9, 2023
Merged

Chore: Set missing colors #27817

merged 22 commits into from Feb 9, 2023

Conversation

juliajforesti
Copy link
Contributor

@juliajforesti juliajforesti commented Jan 23, 2023

DSA-35
DSA-37

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@codecov
Copy link

codecov bot commented Jan 24, 2023

Codecov Report

Merging #27817 (03391da) into develop (082c048) will increase coverage by 0.10%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #27817      +/-   ##
===========================================
+ Coverage    41.62%   41.72%   +0.10%     
===========================================
  Files          849      849              
  Lines        17556    17556              
  Branches      2087     2087              
===========================================
+ Hits          7307     7326      +19     
+ Misses        9973     9957      -16     
+ Partials       276      273       -3     
Flag Coverage Δ
e2e 41.72% <ø> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@MartinSchoeler MartinSchoeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screen Shot 2023-01-24 at 4 46 51 PM

@juliajforesti juliajforesti marked this pull request as ready for review January 30, 2023 15:53
@juliajforesti juliajforesti requested review from a team as code owners January 30, 2023 15:53
@KevLehman
Copy link
Contributor

@juliajforesti , will this PR fix this too?
image

(It's on Omnichannel -> Analytics (and Real Time Monitoring) too) 🙏🏽

@juliajforesti
Copy link
Contributor Author

juliajforesti commented Jan 30, 2023

@KevLehman yes it will 😃 thanks for reporting!

@ggazzo ggazzo merged commit 4b234fe into develop Feb 9, 2023
@ggazzo ggazzo deleted the fix/missing-colors branch February 9, 2023 20:35
gabriellsh added a commit that referenced this pull request Feb 13, 2023
…e/wizard

* 'develop' of github.com:RocketChat/Rocket.Chat:
  [BREAK] Unify monolith and microservices intercommunication on same technology and limit to Enterprise only (#27969)
  [NEW] Emojis rendering properly on quote message previews (#27972)
  Chore: Wait message to not be Busy (#28000)
  Chore: e2e changes tests (#27987)
  [IMPROVE] Audit (#27994)
  [IMPROVE] Registration Experience (#27820)
  [BREAK][ENTERPRISE] Limit presence statuses to 200 concurrent users when running monolith to keep performance (#27854)
  [BREAK] Removed deprecated settings for Legacy Messages, Marked, Snippet Messages, Autolinker and IssueLinks (#27902)
  [NEW] Permission to bypass message editing and removing limits (#27644)
  [FIX] Video Conf Message Blocks not always updating when running on micro services (#27764)
  Chore: Set missing colors (#27817)
  Fix CI
  Chore: undo busy selector
  [BREAK] Remove message view mode from User Preferences (#27867)
  Chore: Aria busy indicators (#27978)
  Chore: Refactor Composer Dropdown (#27931)
  Chore: Added Enterprise Options to Login customization (#27855)
  [FIX] Ignored messages reactivity (#27279)
  [BREAK] [NEW] Custom roles upsell modal (#27707)
@sampaiodiego sampaiodiego mentioned this pull request Feb 17, 2023
@sampaiodiego sampaiodiego mentioned this pull request Mar 9, 2023
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants