Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BREAK] Remove Chatpal #28012

Merged
merged 2 commits into from Feb 13, 2023
Merged

[BREAK] Remove Chatpal #28012

merged 2 commits into from Feb 13, 2023

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Feb 13, 2023

as Chatpal is no longer maintained it makes no sense that we maintain compatibility within Rocket.Chat, luckily some solution with Rocket.Chat.Apps can add some capabilities again

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@codecov
Copy link

codecov bot commented Feb 13, 2023

Codecov Report

Merging #28012 (8611bbe) into develop (6dddfe5) will increase coverage by 0.23%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #28012      +/-   ##
===========================================
+ Coverage    41.52%   41.76%   +0.23%     
===========================================
  Files          833      830       -3     
  Lines        17125    17029      -96     
  Branches      2068     2068              
===========================================
  Hits          7112     7112              
+ Misses        9742     9644      -98     
- Partials       271      273       +2     
Flag Coverage Δ
e2e 41.76% <ø> (+0.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo marked this pull request as ready for review February 13, 2023 19:33
@ggazzo ggazzo requested a review from a team as a code owner February 13, 2023 19:33
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Feb 13, 2023
@ggazzo ggazzo merged commit 1e5a065 into develop Feb 13, 2023
@ggazzo ggazzo deleted the break/chatpal branch February 13, 2023 19:45
@geekgonecrazy
Copy link
Member

you mention apps? Can we add search providers via apps now?? That would be amazing..

@sampaiodiego sampaiodiego mentioned this pull request Feb 17, 2023
@sampaiodiego sampaiodiego mentioned this pull request Mar 9, 2023
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants