Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Client crashing when updating CachedChatSubscription #28062

Merged
merged 3 commits into from Feb 17, 2023

Conversation

gabriellsh
Copy link
Member

@gabriellsh gabriellsh commented Feb 15, 2023

Proposed changes (including videos or screenshots)

Currently the typing of 'ISubscription' is a little off from reality. The property ts is optional, and this can cause crashes when trying to access ts's properties.

I decided to avoid changing the type definitions for ISubscription this time, since it will probably impact many other places, and that's not the scope of this task.

Issue(s)

Steps to test or reproduce

Further comments

TC-472

Co-authored-by: Tasso Evangelista <tasso.evangelista@rocket.chat>
@tassoevan tassoevan added this to the 6.0.0 milestone Feb 15, 2023
@codecov
Copy link

codecov bot commented Feb 16, 2023

Codecov Report

Merging #28062 (2dae5dc) into develop (364a153) will increase coverage by 0.23%.
The diff coverage is 40.80%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #28062      +/-   ##
===========================================
+ Coverage    43.71%   43.94%   +0.23%     
===========================================
  Files          790      791       +1     
  Lines        15258    15329      +71     
  Branches      2084     2103      +19     
===========================================
+ Hits          6670     6737      +67     
+ Misses        8310     8309       -1     
- Partials       278      283       +5     
Flag Coverage Δ
e2e 43.94% <40.80%> (+0.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Feb 16, 2023
@rodrigok rodrigok merged commit fd4793f into develop Feb 17, 2023
@rodrigok rodrigok deleted the fix/firstLogin branch February 17, 2023 01:41
@sampaiodiego sampaiodiego mentioned this pull request Feb 17, 2023
@sampaiodiego sampaiodiego mentioned this pull request Mar 9, 2023
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants