Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Disable video message when composer is in use #28073

Merged
merged 4 commits into from Feb 18, 2023

Conversation

dougfabris
Copy link
Member

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@dougfabris dougfabris requested a review from a team as a code owner February 16, 2023 14:40
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Feb 16, 2023
gabriellsh
gabriellsh previously approved these changes Feb 16, 2023
@codecov
Copy link

codecov bot commented Feb 16, 2023

Codecov Report

Merging #28073 (30e3f63) into develop (0ba5821) will decrease coverage by 5.25%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #28073      +/-   ##
===========================================
- Coverage    43.73%   38.49%   -5.25%     
===========================================
  Files          793      718      -75     
  Lines        15403    14212    -1191     
  Branches      2142     2022     -120     
===========================================
- Hits          6737     5471    -1266     
- Misses        8374     8464      +90     
+ Partials       292      277      -15     
Flag Coverage Δ
e2e 38.48% <ø> (-5.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@kodiakhq kodiakhq bot removed the stat: ready to merge PR tested and approved waiting for merge label Feb 16, 2023
@kodiakhq
Copy link
Contributor

kodiakhq bot commented Feb 16, 2023

This PR currently has a merge conflict. Please resolve this and then re-add the ['stat: ready to merge', 'automerge'] label.

@dougfabris dougfabris requested a review from a team as a code owner February 17, 2023 17:53
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge stat: conflict and removed stat: conflict stat: ready to merge PR tested and approved waiting for merge labels Feb 17, 2023
@dougfabris dougfabris force-pushed the regression/disabled-video-message branch from 9963181 to 4ab5d60 Compare February 17, 2023 18:00
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: conflict labels Feb 17, 2023
@ggazzo ggazzo merged commit 513ba32 into develop Feb 18, 2023
@ggazzo ggazzo deleted the regression/disabled-video-message branch February 18, 2023 02:59
@dougfabris dougfabris added this to the 6.0.0 milestone Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants