Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: QoL improvements to Omnichannel E2E tests #28075

Merged
merged 13 commits into from Feb 17, 2023

Conversation

KevLehman
Copy link
Contributor

@KevLehman KevLehman commented Feb 16, 2023

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

  • Closes dangling contexts after use
  • Run non-block api calls in parallel
  • Refactor suites to be made in steps instead of one by one
  • Updates selectors to be more specific
  • Updates tests to dismiss generated notifications so they don't affect following suites

@KevLehman KevLehman requested a review from a team as a code owner February 16, 2023 17:25
@KevLehman KevLehman marked this pull request as draft February 16, 2023 17:26
@codecov
Copy link

codecov bot commented Feb 16, 2023

Codecov Report

Merging #28075 (7639ce1) into develop (0ba5821) will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #28075      +/-   ##
===========================================
- Coverage    43.73%   43.69%   -0.05%     
===========================================
  Files          793      793              
  Lines        15403    15403              
  Branches      2142     2142              
===========================================
- Hits          6737     6730       -7     
- Misses        8374     8383       +9     
+ Partials       292      290       -2     
Flag Coverage Δ
e2e 43.65% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@KevLehman KevLehman changed the title Chore: tests go brr Chore: QoL improvements to Omnichannel E2E tests Feb 17, 2023
@KevLehman KevLehman marked this pull request as ready for review February 17, 2023 17:08
@KevLehman KevLehman requested a review from a team February 17, 2023 17:09
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Feb 17, 2023
@KevLehman KevLehman added this to the 6.0.0 milestone Feb 17, 2023
@ggazzo
Copy link
Member

ggazzo commented Feb 17, 2023

is that a feature? to be marked as "feat: omnichannel" ?

@ggazzo
Copy link
Member

ggazzo commented Feb 17, 2023

image

@KevLehman
Copy link
Contributor Author

is that a feature? to be marked as "feat: omnichannel" ?

We don't have a "team only" tag. We use the tag to group things that we did so we can find them later :)

@ggazzo
Copy link
Member

ggazzo commented Feb 17, 2023

is that a feature? to be marked as "feat: omnichannel" ?

We don't have a "team only" tag. We use the tag to group things that we did so we can find them later :)

we can create since a bunch of feat: squad were created 🤔

@ggazzo ggazzo merged commit 7b756aa into develop Feb 17, 2023
@ggazzo ggazzo deleted the chore/improve-tests-a-bit branch February 17, 2023 18:58
@KevLehman KevLehman restored the chore/improve-tests-a-bit branch February 22, 2023 16:31
@sampaiodiego sampaiodiego mentioned this pull request Mar 9, 2023
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants