Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Video Recorder "record" button alignment #28122

Merged
merged 1 commit into from Feb 22, 2023

Conversation

tassoevan
Copy link
Contributor

Proposed changes (including videos or screenshots)

Before

image

image

After

image

image

Issue(s)

Steps to test or reproduce

Further comments

@tassoevan tassoevan added this to the 6.0.0 milestone Feb 22, 2023
@tassoevan tassoevan marked this pull request as ready for review February 22, 2023 20:04
@tassoevan tassoevan requested a review from a team as a code owner February 22, 2023 20:04
@codecov
Copy link

codecov bot commented Feb 22, 2023

Codecov Report

Merging #28122 (f31e6a3) into develop (19afbac) will increase coverage by 5.33%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #28122      +/-   ##
===========================================
+ Coverage    39.60%   44.94%   +5.33%     
===========================================
  Files          745      766      +21     
  Lines        14685    14904     +219     
  Branches      2032     2070      +38     
===========================================
+ Hits          5816     6698     +882     
+ Misses        8598     7916     -682     
- Partials       271      290      +19     
Flag Coverage Δ
e2e 44.90% <ø> (+5.32%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo merged commit 2d4e916 into develop Feb 22, 2023
@ggazzo ggazzo deleted the regression/video-recorder-button-alignment branch February 22, 2023 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants