Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Replace useForm in favor of react-hook-form on CreateDiscussion #28249

Merged
merged 1 commit into from Mar 13, 2023

Conversation

juliajforesti
Copy link
Contributor

@juliajforesti juliajforesti commented Mar 2, 2023

DSA-65

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@codecov
Copy link

codecov bot commented Mar 2, 2023

Codecov Report

Merging #28249 (c16d106) into develop (fd33a0f) will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #28249      +/-   ##
===========================================
+ Coverage    44.88%   44.94%   +0.06%     
===========================================
  Files          771      771              
  Lines        14984    14984              
  Branches      2090     2090              
===========================================
+ Hits          6726     6735       +9     
+ Misses        7959     7953       -6     
+ Partials       299      296       -3     
Flag Coverage Δ
e2e 44.90% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@juliajforesti juliajforesti marked this pull request as ready for review March 3, 2023 01:39
@juliajforesti juliajforesti requested a review from a team as a code owner March 3, 2023 01:39
@dougfabris dougfabris added this to the 6.1.0 milestone Mar 3, 2023
@dougfabris dougfabris changed the title Chore: Replace useForm in favor of react-hook-form on CreateDiscussion Chore: Replace useForm in favor of react-hook-form on CreateDiscussion Mar 3, 2023
@ggazzo ggazzo changed the title Chore: Replace useForm in favor of react-hook-form on CreateDiscussion refactor: Replace useForm in favor of react-hook-form on CreateDiscussion Mar 13, 2023
@ggazzo ggazzo merged commit d5f3591 into develop Mar 13, 2023
1 check passed
@ggazzo ggazzo deleted the chore/useForm-CreateDiscussion branch March 13, 2023 14:51
@casalsgh casalsgh modified the milestones: 6.1.0, 6.2.0 Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants