regression: Invalid User registration without username validation #28329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @dudanogueira can you have a look ?✌️ |
|
Hey @hugocostadev can you review this . This is a very important issue. |
chinma-yyy
changed the title
|
Hey @dudanogueira @hugocostadev any comments? |
chinma-yyy
changed the title
yash-rajpal
requested changes
Apr 4, 2023
There was a problem hiding this comment.
Hey @chinma-yyy Can you please resolve the conflicts?
Thanks for the contribution!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #28329 +/- ##
===========================================
+ Coverage 37.07% 45.40% +8.32%
===========================================
Files 623 726 +103
Lines 12324 14279 +1955
Branches 1990 2213 +223
===========================================
+ Hits 4569 6483 +1914
+ Misses 7507 7489 -18
- Partials 248 307 +59
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
hey @yash-rajpal the pr is ready with changes!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Before
After
Issue(s)
closes #28223 One task of this issue is fixed where the invalid username prompt is given to user
On create an account page enter any username that doesn't match the username policy but the prompt is not shown and also the user is created in the database irrespective of the username validation which leads to Email-already-exists error due to user creation in database. The user then thinks that the the account is not created.
Steps to test or reproduce
On create an account page enter any invalid username
Further comments
So I have added a direct check before registerUser method call just after the API call to check for username validation which returns API failure on invalid username . Earlier the user was being registered and then the username was being set by calling setUsername method which resulted in unacceptable results.