docs: Update Pull Request Template #28373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinma-yyy
changed the title
chinma-yyy
changed the title
chinma-yyy
changed the title
dionisio-bot
bot
added
stat: ready to merge
|
Thanks a lot for your contribution @chinma-yyy ! We made a mistake by forgetting to update the template 💯 🚀 |
ggazzo
previously approved these changes
Mar 13, 2023
ggazzo
reviewed
Mar 13, 2023
.github/PULL_REQUEST_TEMPLATE.md
Outdated
| ci: For updating CI configuration | ||
| test: For adding tests | ||
| i18n: For updating any translations | ||
| regression: For fixing any regression |
There was a problem hiding this comment.
here at rocket.chat we actually use the term regression for bugs that were only found in develop, that never made it to an official release
There was a problem hiding this comment.
Ohh, actually the previous template had no explanation and I had no idea about the issue type, so I just added it. Thank you
sampaiodiego
requested changes
Mar 13, 2023
ggazzo
reviewed
Mar 13, 2023
dionisio-bot
bot
added
stat: ready to merge
Co-authored-by: Diego Sampaio <chinello@gmail.com>
dionisio-bot
bot
removed
the
stat: ready to merge
chinma-yyy
requested review from
sampaiodiego and
ggazzo
and removed request for
sampaiodiego
Codecov Report
@@ Coverage Diff @@
## develop #28373 +/- ##
========================================
Coverage 45.26% 45.27%
========================================
Files 760 760
Lines 14795 14795
Branches 2086 2086
========================================
+ Hits 6697 6698 +1
Misses 7804 7804
+ Partials 294 293 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
sampaiodiego
approved these changes
Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Create a pull request to the Rocket Chat repository
Further comments