Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(eslint): Add "no-floating-promises" eslint rule - Part 2 #28464

Merged
merged 8 commits into from Mar 17, 2023

Conversation

rodrigok
Copy link
Member

@rodrigok rodrigok commented Mar 17, 2023

Proposed changes (including videos or screenshots)

Issue(s)

ARCH-171
ARCH-169

Steps to test or reproduce

Further comments

@codecov
Copy link

codecov bot commented Mar 17, 2023

Codecov Report

Merging #28464 (6695ab6) into develop (ffa1d9c) will increase coverage by 2.22%.
The diff coverage is n/a.

❗ Current head 6695ab6 differs from pull request most recent head 9ce5846. Consider uploading reports for the commit 9ce5846 to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #28464      +/-   ##
===========================================
+ Coverage    42.77%   44.99%   +2.22%     
===========================================
  Files          742      755      +13     
  Lines        14528    14615      +87     
  Branches      2076     2094      +18     
===========================================
+ Hits          6214     6576     +362     
+ Misses        8023     7742     -281     
- Partials       291      297       +6     
Flag Coverage Δ
e2e 44.95% <ø> (+2.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Base automatically changed from improve-no-floating-promises-void to develop March 17, 2023 14:27
@rodrigok rodrigok force-pushed the improve-no-floating-promises-tests branch from 3369d2e to 9ce5846 Compare March 17, 2023 16:23
@rodrigok rodrigok marked this pull request as ready for review March 17, 2023 16:58
@rodrigok rodrigok requested review from a team as code owners March 17, 2023 16:58
@ggazzo ggazzo merged commit a035fb5 into develop Mar 17, 2023
33 checks passed
@ggazzo ggazzo deleted the improve-no-floating-promises-tests branch March 17, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants