Fix RocketChat/Rocket.Chat#239 room's message count and last message #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timestamp is not updated when a message is sent. The ChatRoom update selector referenced the wrong (non-existant) field. Thus, the room's message count was never incremented. Also fixes issue where the room's last message timestamp is not set on the room document.
rodrigok
added a commit
that referenced
this pull request
Jul 9, 2015
Fix #239 room's message count and last message
|
Thanks ;) |
This was referenced Mar 16, 2020
This was referenced Nov 18, 2020
Open
This was referenced Sep 15, 2021
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The message count when viewing History is incorrect because the ChatRoom message count and last message timestamp is not updated when a message is sent.
The ChatRoom update selector referenced the wrong (non-existant) field.
Thus, the room's message count was never incremented. Also fixes issue
where the room's last message timestamp is not set on the room document.