Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Subscriptions - 3 #28538

Merged
merged 11 commits into from Mar 26, 2023
Merged

refactor: Subscriptions - 3 #28538

merged 11 commits into from Mar 26, 2023

Conversation

KevLehman
Copy link
Contributor

@KevLehman KevLehman commented Mar 21, 2023

ARCH-931

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@codecov
Copy link

codecov bot commented Mar 21, 2023

Codecov Report

Merging #28538 (5d118d4) into develop (faa7c52) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #28538      +/-   ##
===========================================
+ Coverage    45.03%   45.05%   +0.01%     
===========================================
  Files          753      753              
  Lines        14665    14665              
  Branches      2130     2130              
===========================================
+ Hits          6605     6607       +2     
+ Misses        7758     7756       -2     
  Partials       302      302              
Flag Coverage Δ
e2e 45.01% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@KevLehman KevLehman force-pushed the refactor/subscriptions-model-3 branch from a2b16ac to 97ee783 Compare March 21, 2023 23:10
@KevLehman KevLehman force-pushed the refactor/subscriptions-model-2 branch from 9a1ba98 to 04963c7 Compare March 22, 2023 14:26
@KevLehman KevLehman force-pushed the refactor/subscriptions-model-3 branch from 97ee783 to 4cacd20 Compare March 22, 2023 14:32
@KevLehman KevLehman force-pushed the refactor/subscriptions-model-2 branch from a99a22e to 27010eb Compare March 23, 2023 20:44
Base automatically changed from refactor/subscriptions-model-2 to develop March 24, 2023 13:37
@KevLehman KevLehman force-pushed the refactor/subscriptions-model-3 branch from f739228 to 2b430fe Compare March 24, 2023 14:45
@KevLehman KevLehman marked this pull request as ready for review March 24, 2023 15:47
@KevLehman KevLehman requested review from a team as code owners March 24, 2023 15:47
sampaiodiego
sampaiodiego previously approved these changes Mar 24, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Mar 25, 2023
@kodiakhq kodiakhq bot removed the stat: ready to merge PR tested and approved waiting for merge label Mar 25, 2023
@kodiakhq
Copy link
Contributor

kodiakhq bot commented Mar 25, 2023

This PR currently has a merge conflict. Please resolve this and then re-add the ['stat: ready to merge', 'automerge'] label.

@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Mar 26, 2023
rodrigok
rodrigok previously approved these changes Mar 26, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Mar 26, 2023
rodrigok
rodrigok previously approved these changes Mar 26, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Mar 26, 2023
@rodrigok rodrigok merged commit 8e5a3e9 into develop Mar 26, 2023
41 checks passed
@rodrigok rodrigok deleted the refactor/subscriptions-model-3 branch March 26, 2023 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants