refactor: rooms model remove findOneByIdOrName to async #28596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggazzo
force-pushed
the
refactor/rooms-to-async
branch
from
d0dffb4
to
9c5b4ff
Compare
Codecov Report
@@ Coverage Diff @@
## develop #28596 +/- ##
===========================================
- Coverage 44.99% 44.97% -0.03%
===========================================
Files 753 753
Lines 14665 14665
Branches 2130 2130
===========================================
- Hits 6599 6596 -3
- Misses 7765 7766 +1
- Partials 301 303 +2
Flags with carried forward coverage won't be shown. Click here to find out more. |
KevLehman
requested changes
Mar 24, 2023
Co-authored-by: Kevin Aleman <kaleman960@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments