Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add types for Meteor.userAsync #28597

Merged
merged 1 commit into from Mar 24, 2023

Conversation

KevLehman
Copy link
Contributor

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@KevLehman KevLehman marked this pull request as ready for review March 24, 2023 14:29
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Mar 24, 2023
@sampaiodiego sampaiodiego changed the title refactor: Add types for Meteor.userAsync chore: Add types for Meteor.userAsync Mar 24, 2023
@codecov
Copy link

codecov bot commented Mar 24, 2023

Codecov Report

Merging #28597 (952ef77) into develop (a6ae079) will decrease coverage by 1.15%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #28597      +/-   ##
===========================================
- Coverage    45.01%   43.87%   -1.15%     
===========================================
  Files          753      743      -10     
  Lines        14665    14451     -214     
  Branches      2130     2116      -14     
===========================================
- Hits          6602     6340     -262     
- Misses        7762     7821      +59     
+ Partials       301      290      -11     
Flag Coverage Δ
e2e 43.83% <ø> (-1.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@kodiakhq kodiakhq bot merged commit 57882fc into develop Mar 24, 2023
38 of 39 checks passed
@kodiakhq kodiakhq bot deleted the refactor/meteor.userasync-types branch March 24, 2023 15:25
gabriellsh added a commit that referenced this pull request Mar 24, 2023
…nto fix/avatarEmoji

* 'fix/avatarEmoji' of github.com:RocketChat/Rocket.Chat: (72 commits)
  refactor: `LivechatRooms` removal - 3 (#28506)
  fix: Livechat MessageList not auto scrolling on new message (#28547)
  chore: Add types for `Meteor.userAsync` (#28597)
  refactor: Easy replacements of Meteor.call to Meteor.callAsync (#28595)
  refactor: `Subscriptions` model - 2x (#28535)
  refactor: `LivechatRooms` 2 (#28504)
  regression: ldap sync not working (#28583)
  fix: Generic Table Search (#28401)
  refactor: Remove `Apps persistence` model (#28510)
  refactor(models): Use Messages Raw model (5/N) (#28590)
  refactor: federation promise.await methods 2/N (#28593)
  refactor: federation Promise.await 1/N (#28591)
  feat: Make the marketplace search bar placeholder dynamic (#28394)
  fix: Bring unseen app requests badge back and minor refactors (#28348)
  refactor: Remove `apps` & `app logs` models (#28509)
  refactor: Convert meteor call to callAsync (2/N) (#28588)
  refactor: Remove `Meteor.call` in favor of `Meteor.callAsync` - 1 (#28576)
  refactor: Restore removed function for counting on LivechatDepartmentAgents (#28577)
  refactor: Convert meteor call to callAsync (#28575)
  refactor: Remove optional return of room coordinator (#28592)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants