Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove promise.await N/N #28643

Merged
merged 4 commits into from Mar 28, 2023
Merged

Conversation

KevLehman
Copy link
Contributor

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@codecov
Copy link

codecov bot commented Mar 27, 2023

Codecov Report

Merging #28643 (0a1056b) into develop (ead5f09) will increase coverage by 2.31%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #28643      +/-   ##
===========================================
+ Coverage    40.24%   42.55%   +2.31%     
===========================================
  Files          732      704      -28     
  Lines        14447    13537     -910     
  Branches      2093     1983     -110     
===========================================
- Hits          5814     5761      -53     
+ Misses        8348     7504     -844     
+ Partials       285      272      -13     
Flag Coverage Δ
e2e 42.53% <ø> (+2.31%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@KevLehman KevLehman marked this pull request as ready for review March 27, 2023 18:32
@KevLehman KevLehman requested review from a team as code owners March 27, 2023 18:32
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Mar 27, 2023
ggazzo
ggazzo previously requested changes Mar 27, 2023
apps/meteor/ee/server/apps/cron.js Show resolved Hide resolved
apps/meteor/server/lib/pushConfig.ts Show resolved Hide resolved
@kodiakhq kodiakhq bot removed the stat: ready to merge PR tested and approved waiting for merge label Mar 27, 2023
@kodiakhq
Copy link
Contributor

kodiakhq bot commented Mar 27, 2023

This PR currently has a merge conflict. Please resolve this and then re-add the ['stat: ready to merge', 'automerge'] label.

@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: conflict labels Mar 28, 2023
@ggazzo ggazzo merged commit fa4e313 into develop Mar 28, 2023
8 of 9 checks passed
@ggazzo ggazzo deleted the refactor/more-promise-await branch March 28, 2023 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants