refactor: Remove Users from fibers 3N #28669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcosSpessatto
commented
Mar 28, 2023
…bers-from-users-3
ggazzo
reviewed
Mar 28, 2023
ggazzo
previously approved these changes
Mar 28, 2023
dionisio-bot
bot
added
stat: ready to merge
Codecov Report
@@ Coverage Diff @@
## develop #28669 +/- ##
===========================================
+ Coverage 45.23% 45.25% +0.02%
===========================================
Files 743 743
Lines 14482 14482
Branches 2239 2239
===========================================
+ Hits 6551 6554 +3
+ Misses 7625 7621 -4
- Partials 306 307 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
…etChat/Rocket.Chat into refactor/remove-fibers-from-users-3
kodiakhq
bot
removed
the
stat: ready to merge
|
This PR currently has a merge conflict. Please resolve this and then re-add the |
…etChat/Rocket.Chat into refactor/remove-fibers-from-users-3
ggazzo
reviewed
Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments